chrome/browser/extensions/extension_action.cc - Issue 1168383002: Implement sidebar support for extension action popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action.cc

diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc

index af9e8685934c872f5e0e5b4aa3cdab328156bc93..88be8504c905477519596b935486b8be0523f462 100644

--- a/chrome/browser/extensions/extension_action.cc

+++ b/chrome/browser/extensions/extension_action.cc

@@ -309,6 +309,7 @@ void ExtensionAction::Populate(const extensions::Extension& extension,

SetTitle(kDefaultTabId, title);

SetPopupUrl(kDefaultTabId, manifest_data.default_popup_url);

set_id(manifest_data.id);

+ set_open_in_sidebar(manifest_data.open_in_sidebar);

// Initialize the specified icon set.

if (!manifest_data.default_icon.empty())