Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: chrome/browser/download/download_shelf.h

Issue 11673004: No need to pass DownloadItemModel ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DownloadShelfContextMenu class cleanup and require GetMenuModel() to return non-NULL Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_item_model.cc ('k') | chrome/browser/download/download_shelf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_shelf.h
diff --git a/chrome/browser/download/download_shelf.h b/chrome/browser/download/download_shelf.h
index f77bf02bffe5a1f2d32bed174fe44fecc3c5dc8e..b04b5c2075341056fdc63872cef681a5619b5a95 100644
--- a/chrome/browser/download/download_shelf.h
+++ b/chrome/browser/download/download_shelf.h
@@ -5,7 +5,10 @@
#ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_SHELF_H_
#define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_SHELF_H_
-class DownloadItemModel;
+namespace content {
+class DownloadItem;
+}
+
class Browser;
// This is an abstract base class for platform specific download shelf
@@ -15,9 +18,9 @@ class DownloadShelf {
DownloadShelf();
virtual ~DownloadShelf() {}
- // A new download has started, so add it to our shelf. This object will
- // take ownership of |download_model|. Also make the shelf visible.
- void AddDownload(DownloadItemModel* download_model);
+ // A new download has started, so add it to our shelf. Also make the shelf
+ // visible.
+ void AddDownload(content::DownloadItem* download);
// The browser view needs to know when we are going away to properly return
// the resize corner size to WebKit so that we don't draw on top of it.
@@ -47,7 +50,7 @@ class DownloadShelf {
bool is_hidden() { return is_hidden_; }
protected:
- virtual void DoAddDownload(DownloadItemModel* download_model) = 0;
+ virtual void DoAddDownload(content::DownloadItem* download) = 0;
virtual void DoShow() = 0;
virtual void DoClose() = 0;
« no previous file with comments | « chrome/browser/download/download_item_model.cc ('k') | chrome/browser/download/download_shelf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698