chrome/browser/download/download_shelf.cc - Issue 11673004: No need to pass DownloadItemModel ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf.cc

Issue 11673004: No need to pass DownloadItemModel ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DownloadShelfContextMenu class cleanup and require GetMenuModel() to return non-NULL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_shelf.cc

diff --git a/chrome/browser/download/download_shelf.cc b/chrome/browser/download/download_shelf.cc

index fa4f4532526d63f9b0430cc9058d82ae6cd22816..524ff7d5589d6da7c928043a2da0abd356960c36 100644

--- a/chrome/browser/download/download_shelf.cc

+++ b/chrome/browser/download/download_shelf.cc

@@ -8,11 +8,11 @@ DownloadShelf::DownloadShelf()

: should_show_on_unhide_(false),

is_hidden_(false) {}

-void DownloadShelf::AddDownload(DownloadItemModel* download_model) {

+void DownloadShelf::AddDownload(content::DownloadItem* download) {

if (is_hidden_)

Unhide();

Show();

- DoAddDownload(download_model);

+ DoAddDownload(download);

}

void DownloadShelf::Show() {