chrome/browser/download/download_item_model.cc - Issue 11673004: No need to pass DownloadItemModel ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item_model.cc

Issue 11673004: No need to pass DownloadItemModel ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DownloadShelfContextMenu class cleanup and require GetMenuModel() to return non-NULL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_item_model.cc

diff --git a/chrome/browser/download/download_item_model.cc b/chrome/browser/download/download_item_model.cc

index 66f24ea2e2a684e7cecae2816b95ed81e8284954..d6242b14f2c8a9b3e7056bec881a3da476f53741 100644

--- a/chrome/browser/download/download_item_model.cc

+++ b/chrome/browser/download/download_item_model.cc

@@ -218,10 +218,6 @@ DownloadItemModel::DownloadItemModel(DownloadItem* download)

DownloadItemModel::~DownloadItemModel() {

}

-void DownloadItemModel::CancelTask() {

- download_->Cancel(true /* update history service */);

string16 DownloadItemModel::GetInterruptReasonText() const {

if (download_->GetState() != DownloadItem::INTERRUPTED ||

download_->GetLastReason() ==