Split getIntrinsicDimensions into four pieces

Split getIntrinsicDimensions into four pieces

This CL splits getIntrinsicDimensions into getMinIntrinsicWidth,
getMaxIntrinsicWidth, getMinIntrinsicHeight, and getMaxIntrinsicHeight so that
we can properly shrink-wrap the stocks app menu. This CL just contains the
refactoring. The use in stocks app will come in a later CL.

R=ianh@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/468813fa245a79b274d3144c1fd4bd15203d5ee0

[Hixie, 2015-06-08 21:35:32]

lgtm

https://codereview.chromium.org/1167293003/diff/1/sky/examples/lib/solid_colo...
File sky/examples/lib/solid_color_box.dart (right):

https://codereview.chromium.org/1167293003/diff/1/sky/examples/lib/solid_colo...
sky/examples/lib/solid_color_box.dart:16: double
getMinIntrinsicWidth(BoxConstraints constraints) {
this seems wrong.

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
File sky/sdk/lib/framework/rendering/block.dart (right):

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
sky/sdk/lib/framework/rendering/block.dart:55: assert(width < double.INFINITY);
i don't think you need this anymore

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
File sky/sdk/lib/framework/rendering/box.dart (right):

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
sky/sdk/lib/framework/rendering/box.dart:130: double
getMinIntrinsicWidth(BoxConstraints constraints) {
Let's define these here.

// getMinIntrinsicWidth() should return the minimum width that this box could 
// be without failing to render its contents within itself.

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
sky/sdk/lib/framework/rendering/box.dart:134: double
getMaxIntrinsicWidth(BoxConstraints constraints) {
// getMaxIntrinsicWidth() should return the smallest width beyond which 
// increasing the width never decreases the height.

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
sky/sdk/lib/framework/rendering/box.dart:138: double
getMinIntrinsicHeight(BoxConstraints constraints) {
// getMinIntrinsicHeight() should return the minimum height that this box could 
// be without failing to render its contents within itself.

https://codereview.chromium.org/1167293003/diff/1/sky/sdk/lib/framework/rende...
sky/sdk/lib/framework/rendering/box.dart:142: double
getMaxIntrinsicHeight(BoxConstraints constraints) {
// getMaxIntrinsicHeight should return the smallest height beyond which
// increasing the height never decreases the width.
// If the layout algorithm used is width-in-height-out, i.e. the height
// depends on the width and not vice versa, then this will return the same
// as getMinIntrinsicHeight().

[abarth-chromium, 2015-06-08 21:40:38]

Committed patchset #2 (id:20001) manually as
468813fa245a79b274d3144c1fd4bd15203d5ee0 (presubmit successful).