Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: sky/sdk/lib/framework/rendering/paragraph.dart

Issue 1167293003: Split getIntrinsicDimensions into four pieces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: more worky Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/rendering/flex.dart ('k') | sky/sdk/lib/framework/rendering/stack.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/paragraph.dart
diff --git a/sky/sdk/lib/framework/rendering/paragraph.dart b/sky/sdk/lib/framework/rendering/paragraph.dart
index 911ad15ed0b9f92ab62aa2b7de950703264313e8..58ad8915d459db8709859e852a9cc37d835bd2d0 100644
--- a/sky/sdk/lib/framework/rendering/paragraph.dart
+++ b/sky/sdk/lib/framework/rendering/paragraph.dart
@@ -40,10 +40,28 @@ class RenderParagraph extends RenderBox {
}
}
- Size getIntrinsicDimensions(BoxConstraints constraints) {
+ // We don't currently support this for RenderParagraph
+ double getMinIntrinsicWidth(BoxConstraints constraints) {
assert(false);
- return null;
- // we don't currently support this for RenderParagraph
+ return constraints.constrainWidth(0.0);
+ }
+
+ // We don't currently support this for RenderParagraph
+ double getMaxIntrinsicWidth(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainWidth(0.0);
+ }
+
+ // We don't currently support this for RenderParagraph
+ double getMinIntrinsicHeight(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainHeight(0.0);
+ }
+
+ // We don't currently support this for RenderParagraph
+ double getMaxIntrinsicHeight(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainHeight(0.0);
}
void performLayout() {
« no previous file with comments | « sky/sdk/lib/framework/rendering/flex.dart ('k') | sky/sdk/lib/framework/rendering/stack.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698