Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: sky/sdk/lib/framework/rendering/flex.dart

Issue 1167293003: Split getIntrinsicDimensions into four pieces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: more worky Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/rendering/box.dart ('k') | sky/sdk/lib/framework/rendering/paragraph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/flex.dart
diff --git a/sky/sdk/lib/framework/rendering/flex.dart b/sky/sdk/lib/framework/rendering/flex.dart
index 1a0a1f61d1a0760f3a0749ae573f818e02d81366..0a1921dbe225597e5f00d73c62b8242ed6361a8a 100644
--- a/sky/sdk/lib/framework/rendering/flex.dart
+++ b/sky/sdk/lib/framework/rendering/flex.dart
@@ -39,6 +39,30 @@ class RenderFlex extends RenderBox with ContainerRenderObjectMixin<RenderBox, Fl
child.parentData = new FlexBoxParentData();
}
+ // We don't currently support this for RenderFlex
+ double getMinIntrinsicWidth(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainWidth(0.0);
+ }
+
+ // We don't currently support this for RenderFlex
+ double getMaxIntrinsicWidth(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainWidth(0.0);
+ }
+
+ // We don't currently support this for RenderFlex
+ double getMinIntrinsicHeight(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainHeight(0.0);
+ }
+
+ // We don't currently support this for RenderFlex
+ double getMaxIntrinsicHeight(BoxConstraints constraints) {
+ assert(false);
+ return constraints.constrainHeight(0.0);
+ }
+
bool get sizedByParent => true;
void performResize() {
size = constraints.constrain(new Size(constraints.maxWidth, constraints.maxHeight));
« no previous file with comments | « sky/sdk/lib/framework/rendering/box.dart ('k') | sky/sdk/lib/framework/rendering/paragraph.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698