Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1166993002: Towards removing getTexture() from SkImage (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Towards removing getTexture() on SkImage Committed: https://skia.googlesource.com/skia/+/55812362f1df3c1f7341f687d5bab0adab8ac954

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : comments #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -25 lines) Patch
M gyp/utils.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImage.h View 1 2 2 chunks +15 lines, -7 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage.cpp View 1 3 chunks +36 lines, -4 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
bsalomon
5 years, 6 months ago (2015-06-04 17:54:07 UTC) #2
reed1
SK_ATTR_DEPRECATED("info") is nice in that it triggers a warning (at least on the mac) if ...
5 years, 6 months ago (2015-06-04 19:44:01 UTC) #3
robertphillips
lgtm
5 years, 6 months ago (2015-06-05 16:30:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166993002/40001
5 years, 6 months ago (2015-06-05 16:30:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 16:35:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166993002/60001
5 years, 6 months ago (2015-06-10 15:44:11 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 15:49:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/55812362f1df3c1f7341f687d5bab0adab8ac954

Powered by Google App Engine
This is Rietveld 408576698