Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 116693004: Move v8 into third_party. (Closed)

Created:
6 years, 11 months ago by jcgregorio
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@path
Visibility:
Public.

Description

Move v8 into third_party. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12954

Patch Set 1 #

Patch Set 2 : move to local v8 copy #

Patch Set 3 : clean up gyp #

Patch Set 4 : drop file #

Patch Set 5 : again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -41 lines) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/SkV8Example/Global.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M experimental/SkV8Example/JsContext.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M experimental/SkV8Example/Path.cpp View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
A experimental/SkV8Example/README View 1 chunk +16 lines, -0 lines 0 comments Download
M gyp/v8.gyp View 1 2 1 chunk +24 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jcgregorio
6 years, 11 months ago (2014-01-07 21:00:19 UTC) #1
robertphillips
lgtm
6 years, 11 months ago (2014-01-08 13:12:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/116693004/100001
6 years, 11 months ago (2014-01-08 13:18:17 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 15:14:13 UTC) #4
Message was sent while issue was closed.
Change committed as 12954

Powered by Google App Engine
This is Rietveld 408576698