Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: experimental/SkV8Example/Global.cpp

Issue 116693004: Move v8 into third_party. (Closed) Base URL: https://skia.googlesource.com/skia.git@path
Patch Set: again Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | experimental/SkV8Example/JsContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/SkV8Example/Global.cpp
diff --git a/experimental/SkV8Example/Global.cpp b/experimental/SkV8Example/Global.cpp
index 998f92bb73726236b59e2b131809634312ffc276..e8ad318d40268c8cd3346d2e5f21d0b9c06649ca 100644
--- a/experimental/SkV8Example/Global.cpp
+++ b/experimental/SkV8Example/Global.cpp
@@ -127,7 +127,7 @@ void Global::SetTimeout(const v8::FunctionCallbackInfo<v8::Value>& args) {
evt->setFast32(id);
evt->postDelay(delay);
- args.GetReturnValue().Set(Integer::New(id));
+ args.GetReturnValue().Set(Integer::New(gGlobal->fIsolate, id));
}
// Callback function for SkEvents used to implement timeouts.
@@ -180,11 +180,11 @@ Handle<Context> Global::createRootContext() {
Handle<ObjectTemplate> global = ObjectTemplate::New();
global->Set(v8::String::NewFromUtf8(fIsolate, "print"),
- v8::FunctionTemplate::New(Global::Print));
+ v8::FunctionTemplate::New(fIsolate, Global::Print));
global->Set(v8::String::NewFromUtf8(fIsolate, "setTimeout"),
- v8::FunctionTemplate::New(Global::SetTimeout));
+ v8::FunctionTemplate::New(fIsolate, Global::SetTimeout));
global->Set(v8::String::NewFromUtf8(fIsolate, "inval"),
- v8::FunctionTemplate::New(Global::Inval));
+ v8::FunctionTemplate::New(fIsolate, Global::Inval));
return Context::New(fIsolate, NULL, global);
« no previous file with comments | « DEPS ('k') | experimental/SkV8Example/JsContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698