Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1166793006: bindings: Stop using the given creationContext in public APIs. (Closed)

Created:
5 years, 6 months ago by Yuki
Modified:
5 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik, blink-reviews-bindings_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Stop using the given creationContext in public APIs. The creation context passed through the public APIs may be unsafe and faked by user script. The callers of the APIs often do not check if the context is safe and valid or not. Plus, there shouldn't be a case that a caller needs to handle cross-origin cases, so let us always use the current context instead of the creation context given through the callers, which are not reliable. BUG=497507 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M Source/web/WebArrayBufferConverter.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/web/WebBlob.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/web/WebDOMError.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/web/WebDOMFileSystem.cpp View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL? I'm now running browser_tests locally.
5 years, 6 months ago (2015-06-08 10:35:10 UTC) #2
haraken
LGTM. It is nasty to ignore the passed-in creationContext and use the current context instead, ...
5 years, 6 months ago (2015-06-08 10:55:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166793006/1
5 years, 6 months ago (2015-06-09 10:04:18 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 11:34:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196755

Powered by Google App Engine
This is Rietveld 408576698