Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2134)

Unified Diff: Source/web/WebDOMFileSystem.cpp

Issue 1166793006: bindings: Stop using the given creationContext in public APIs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebDOMError.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDOMFileSystem.cpp
diff --git a/Source/web/WebDOMFileSystem.cpp b/Source/web/WebDOMFileSystem.cpp
index ee76badb1364c8e72e64b54f6e424207b4dd89b6..93d627a1fdfc91e813b09512a3d06426b6eb3f09 100644
--- a/Source/web/WebDOMFileSystem.cpp
+++ b/Source/web/WebDOMFileSystem.cpp
@@ -116,11 +116,13 @@ WebURL WebDOMFileSystem::rootURL() const
return m_private->rootURL();
}
-v8::Local<v8::Value> WebDOMFileSystem::toV8Value(v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
+v8::Local<v8::Value> WebDOMFileSystem::toV8Value(v8::Local<v8::Object> /* creationContext */, v8::Isolate* isolate)
{
+ // We no longer use |creationContext| because it's often misused and points
+ // to a context faked by user script.
if (!m_private.get())
return v8::Local<v8::Value>();
- return toV8(m_private.get(), creationContext, isolate);
+ return toV8(m_private.get(), isolate->GetCurrentContext()->Global(), isolate);
}
v8::Local<v8::Value> WebDOMFileSystem::createV8Entry(
@@ -132,9 +134,9 @@ v8::Local<v8::Value> WebDOMFileSystem::createV8Entry(
if (!m_private.get())
return v8::Local<v8::Value>();
if (entryType == EntryTypeDirectory)
- return toV8(DirectoryEntry::create(m_private.get(), path), creationContext, isolate);
+ return toV8(DirectoryEntry::create(m_private.get(), path), isolate->GetCurrentContext()->Global(), isolate);
ASSERT(entryType == EntryTypeFile);
- return toV8(FileEntry::create(m_private.get(), path), creationContext, isolate);
+ return toV8(FileEntry::create(m_private.get(), path), isolate->GetCurrentContext()->Global(), isolate);
}
WebDOMFileSystem::WebDOMFileSystem(DOMFileSystem* domFileSystem)
« no previous file with comments | « Source/web/WebDOMError.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698