Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: vm/ast.h

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/isolate.cc ('k') | vm/ast.cc » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/ast.h
===================================================================
--- vm/ast.h (revision 16583)
+++ vm/ast.h (working copy)
@@ -374,7 +374,7 @@
ASSERT(type_.IsZoneHandle());
ASSERT(!type_.IsNull());
ASSERT(type_.IsFinalized());
- ASSERT(dst_name_.IsZoneHandle());
+ ASSERT(dst_name_.IsNotTemporaryScopedHandle());
}
AstNode* expr() const { return expr_; }
@@ -448,13 +448,13 @@
public:
PrimaryNode(intptr_t token_pos, const Object& primary)
: AstNode(token_pos), primary_(primary) {
- ASSERT(primary_.IsZoneHandle());
+ ASSERT(primary_.IsNotTemporaryScopedHandle());
}
const Object& primary() const { return primary_; }
bool IsSuper() const {
- return primary().IsString() && (primary().raw() == Symbols::Super());
+ return primary().IsString() && (primary().raw() == Symbols::Super().raw());
}
virtual void VisitChildren(AstNodeVisitor* visitor) const;
@@ -1201,7 +1201,7 @@
function_name_(function_name),
arguments_(arguments) {
ASSERT(receiver_ != NULL);
- ASSERT(function_name_.IsZoneHandle());
+ ASSERT(function_name_.IsNotTemporaryScopedHandle());
ASSERT(function_name_.IsSymbol());
ASSERT(arguments_ != NULL);
}
@@ -1235,7 +1235,7 @@
receiver_(receiver),
field_name_(field_name) {
ASSERT(receiver_ != NULL);
- ASSERT(field_name_.IsZoneHandle());
+ ASSERT(field_name_.IsNotTemporaryScopedHandle());
ASSERT(field_name_.IsSymbol());
}
« no previous file with comments | « lib/isolate.cc ('k') | vm/ast.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698