Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: vm/ast.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/ast.h ('k') | vm/class_finalizer.cc » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/ast.cc
===================================================================
--- vm/ast.cc (revision 16583)
+++ vm/ast.cc (working copy)
@@ -413,10 +413,8 @@
const Class& cls = Class::Handle(function().Owner());
const String& cls_name = String::Handle(cls.Name());
const String& func_name = String::Handle(function().name());
- const String& error_cls_name = String::Handle(Symbols::NoSuchMethodError());
- const String& error_func_name = String::Handle(Symbols::ThrowNew());
- if (cls_name.Equals(error_cls_name) &&
- func_name.StartsWith(error_func_name)) {
+ if (cls_name.Equals(Symbols::NoSuchMethodError()) &&
+ func_name.StartsWith(Symbols::ThrowNew())) {
return this;
}
return NULL;
« no previous file with comments | « vm/ast.h ('k') | vm/class_finalizer.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698