Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: lib/isolate.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/integers.cc ('k') | vm/ast.h » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/isolate.cc
===================================================================
--- lib/isolate.cc (revision 16583)
+++ lib/isolate.cc (working copy)
@@ -60,18 +60,13 @@
if (func.IsNull()) {
Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
ASSERT(!isolate_lib.IsNull());
- const String& public_class_name =
- String::Handle(Symbols::New("_ReceivePortImpl"));
const String& class_name =
- String::Handle(isolate_lib.PrivateName(public_class_name));
- const String& function_name =
- String::Handle(Symbols::New("_get_or_create"));
- const Array& kNoArgumentNames = Array::Handle();
+ String::Handle(isolate_lib.PrivateName(Symbols::_ReceivePortImpl()));
func = Resolver::ResolveStatic(isolate_lib,
class_name,
- function_name,
+ Symbols::_get_or_create(),
kNumArguments,
- kNoArgumentNames,
+ Object::empty_array(),
Resolver::kIsQualified);
isolate->object_store()->set_receive_port_create_function(func);
}
« no previous file with comments | « lib/integers.cc ('k') | vm/ast.h » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698