Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1166463004: Revert of Adding status to swap complete (Closed)

Created:
5 years, 6 months ago by vabr (Chromium)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding status to swap complete (patchset #18 id:340001 of https://codereview.chromium.org/1084173004/) Reason for revert: Looks like this broke compilation on http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/17401. Speculatively reverting for now. If confirmed, will file a bug with details, otherwise re-revert. Cheers, your sheriff Original issue's description: > Adding status to swap buffers completion > > This will give us more options than completing all swaps successfully, or losing context > > BUG=476966 > TBR=torne - approved interface change > > Committed: https://crrev.com/c794eda78e9ba3c46b550b433e9fe5a248d40104 > Cr-Commit-Position: refs/heads/master@{#331906} TBR=alexst@chromium.org,danakj@chromium.org,dnicoara@chromium.org,nasko@chromium.org,piman@chromium.org,spang@chromium.org,torne@chromium.org,dcheng@chromium.org,achaulk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476966 Committed: https://crrev.com/9b3f11392a034ab4479126eede391e253c7c0969 Cr-Commit-Position: refs/heads/master@{#331939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -315 lines) Patch
M android_webview/browser/aw_gl_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_gl_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 3 chunks +2 lines, -5 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 3 chunks +2 lines, -5 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 3 chunks +3 lines, -5 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 4 chunks +13 lines, -20 lines 0 comments Download
M content/common/gpu/image_transport_surface_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.mm View 2 chunks +5 lines, -9 lines 0 comments Download
M content/common/gpu/image_transport_surface_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/null_transport_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/null_transport_surface.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gl_surface_mock.h View 2 chunks +3 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/swap_result.h View 1 chunk +0 lines, -19 lines 0 comments Download
M ui/gl/gl_surface.h View 5 chunks +5 lines, -6 lines 0 comments Download
M ui/gl/gl_surface.cc View 5 chunks +12 lines, -16 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 5 chunks +14 lines, -16 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_osmesa.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_osmesa.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/gl/gl_surface_ozone.cc View 12 chunks +26 lines, -32 lines 0 comments Download
M ui/gl/gl_surface_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_wgl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_wgl.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M ui/gl/gl_surface_win.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M ui/gl/gl_surface_x11.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M ui/ozone/platform/cast/surface_ozone_egl_cast.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/crtc_controller.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_surface.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surface.cc View 5 chunks +5 lines, -9 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.h View 3 chunks +1 line, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/page_flip_request.h View 1 chunk +3 lines, -8 lines 0 comments Download
M ui/ozone/platform/drm/gpu/page_flip_request.cc View 1 chunk +6 lines, -15 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/public/surface_ozone_egl.h View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Created Revert of Adding status to swap complete
5 years, 6 months ago (2015-05-29 10:39:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166463004/1
5 years, 6 months ago (2015-05-29 10:39:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 10:40:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b3f11392a034ab4479126eede391e253c7c0969 Cr-Commit-Position: refs/heads/master@{#331939}
5 years, 6 months ago (2015-05-29 10:41:37 UTC) #4
vabr (Chromium)
5 years, 6 months ago (2015-05-29 11:00:51 UTC) #5
Message was sent while issue was closed.
On 2015/05/29 10:41:37, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9b3f11392a034ab4479126eede391e253c7c0969
> Cr-Commit-Position: refs/heads/master@{#331939}

More info in http://crbug.com/493649

Powered by Google App Engine
This is Rietveld 408576698