Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1166373003: Let CrWinClang64(dbg) use gn. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org, hans
Base URL:
http://src.chromium.org/chrome/trunk/tools/build/
Project:
build
Visibility:
Public.

Description

Let CrWinClang64(dbg) use gn. BUG=498033 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295579

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -249 lines) Patch
M scripts/slave/recipe_modules/chromium/chromium_fyi.py View 3 chunks +6 lines, -3 lines 2 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 4 chunks +20 lines, -73 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg__tester.json View 3 chunks +4 lines, -173 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Nico
https://codereview.chromium.org/1166373003/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right): https://codereview.chromium.org/1166373003/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py#newcode558 scripts/slave/recipe_modules/chromium/chromium_fyi.py:558: #'enable_swarming': True, I guess I didn't have to change ...
5 years, 6 months ago (2015-06-09 05:09:36 UTC) #2
Nico
(forgot to cc hans)
5 years, 6 months ago (2015-06-09 05:09:47 UTC) #3
Dirk Pranke
lgtm https://codereview.chromium.org/1166373003/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right): https://codereview.chromium.org/1166373003/diff/1/scripts/slave/recipe_modules/chromium/chromium_fyi.py#newcode558 scripts/slave/recipe_modules/chromium/chromium_fyi.py:558: #'enable_swarming': True, On 2015/06/09 05:09:36, Nico wrote: > ...
5 years, 6 months ago (2015-06-09 15:50:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166373003/1
5 years, 6 months ago (2015-06-09 15:52:22 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 15:56:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295579

Powered by Google App Engine
This is Rietveld 408576698