Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: scripts/slave/recipe_modules/chromium/chromium_fyi.py

Issue 1166373003: Let CrWinClang64(dbg) use gn. (Closed) Base URL: http://src.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/chromium_fyi.py
===================================================================
--- scripts/slave/recipe_modules/chromium/chromium_fyi.py (revision 295571)
+++ scripts/slave/recipe_modules/chromium/chromium_fyi.py (working copy)
@@ -542,6 +542,7 @@
},
'CrWinClang64(dbg)': {
'chromium_config': 'chromium_win_clang',
+ 'chromium_apply_config': ['mb'],
'gclient_config': 'chromium',
'chromium_config_kwargs': {
'BUILD_CONFIG': 'Debug',
@@ -552,8 +553,9 @@
'testing': {
'platform': 'win',
},
- 'use_isolate': True,
- 'enable_swarming': True,
+ # TODO(thakis): Reenable when swarming works in gn http://crbug.com/480053
+ #'use_isolate': True,
+ #'enable_swarming': True,
Nico 2015/06/09 05:09:36 I guess I didn't have to change the json file in h
Dirk Pranke 2015/06/09 15:50:01 Yeah, but probably better to be clearer anyway.
# Workaround so that recipes doesn't add random build targets to our
# compile line. We want to build everything.
'add_tests_as_compile_targets': False,
@@ -573,7 +575,8 @@
'testing': {
'platform': 'win',
},
- 'enable_swarming': True,
+ # TODO(thakis): Reenable when swarming works in gn http://crbug.com/480053
+ #'enable_swarming': True,
},
'CrWinClang64(dll)': {
'chromium_config': 'chromium_win_clang',

Powered by Google App Engine
This is Rietveld 408576698