Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1170063002: Add mb config for CrWinClang64(dbg). (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mb config for CrWinClang64(dbg). Since GN doesn't support swarming yet, update its corresponding tester config to not use swarming. (If tester cycle time gets too high, I will remove a few tests – we have enough gyp-based bots to not really lose coverage.) This won't have an effect until the recipe is updated to use mb on this bot (which is blocked on the next ffmpeg roll). BUG=491209 Committed: https://crrev.com/92478e96a57d4f52032a9be47132e9455d9dd160 Cr-Commit-Position: refs/heads/master@{#333429}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 3

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 3 4 chunks +0 lines, -25 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Nico
5 years, 6 months ago (2015-06-09 00:53:41 UTC) #2
Dirk Pranke
lgtm w/ suggested change. https://codereview.chromium.org/1170063002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1170063002/diff/60001/tools/mb/mb_config.pyl#newcode34 tools/mb/mb_config.pyl:34: ['gn', 'clang', 'debug', 'shared', 'minimal_symbols'], ...
5 years, 6 months ago (2015-06-09 01:14:53 UTC) #3
Nico
https://codereview.chromium.org/1170063002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1170063002/diff/60001/tools/mb/mb_config.pyl#newcode34 tools/mb/mb_config.pyl:34: ['gn', 'clang', 'debug', 'shared', 'minimal_symbols'], On 2015/06/09 01:14:52, Dirk ...
5 years, 6 months ago (2015-06-09 01:19:25 UTC) #4
Nico
I added a comment about this. I can remove the win_ prefix, but other platforms ...
5 years, 6 months ago (2015-06-09 01:21:40 UTC) #5
Dirk Pranke
On 2015/06/09 01:21:40, Nico wrote: > I added a comment about this. I can remove ...
5 years, 6 months ago (2015-06-09 01:23:36 UTC) #6
Nico
Thanks!
5 years, 6 months ago (2015-06-09 01:24:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1170063002/70001
5 years, 6 months ago (2015-06-09 01:25:12 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 6 months ago (2015-06-09 02:33:03 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 02:33:53 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/92478e96a57d4f52032a9be47132e9455d9dd160
Cr-Commit-Position: refs/heads/master@{#333429}

Powered by Google App Engine
This is Rietveld 408576698