Sky: Allow clients to specify tile mode for gradients (repeating or mirror).

Sky: Allow clients to specify tile mode for gradients (repeating or mirror).

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/00743aa9758d6de3d7ebb932c4c4173f20a19da2

[Matt Perry, 2015-06-09 17:41:12]

mpcomplete@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-06-09 17:45:22]

lgtm

Looks OK except for the ugly idl/c++.  Can't we make those smarter to use an
enum?  Presumably we need some sort of extended attribute for specifying enum
conversions from idl?

https://codereview.chromium.org/1166223004/diff/1/sky/engine/core/painting/Ca...
File sky/engine/core/painting/CanvasGradient.h (right):

https://codereview.chromium.org/1166223004/diff/1/sky/engine/core/painting/Ca...
sky/engine/core/painting/CanvasGradient.h:25: unsigned tile_mode);
Why can't the C++ use an enum?

[Matt Perry, 2015-06-09 19:01:26]

https://codereview.chromium.org/1166223004/diff/1/sky/engine/core/painting/Ca...
File sky/engine/core/painting/CanvasGradient.h (right):

https://codereview.chromium.org/1166223004/diff/1/sky/engine/core/painting/Ca...
sky/engine/core/painting/CanvasGradient.h:25: unsigned tile_mode);
On 2015/06/09 17:45:22, eseidel wrote:
> Why can't the C++ use an enum?

It can, but then I'd have to write code to do the conversion. I figured that
since we have type safety on the Dart side, we don't need the extra code on the
C++ side. WDYT?

[eseidel, 2015-06-09 19:02:49]

It's less about the safety and more about the readability.  We should make doing
that kind of conversion easy, we're going to end up with a lot of them. :)

Regardless, it doesn't need to block landing this change, but something we do
need to fix in the longer term.

[Matt Perry, 2015-06-09 19:21:49]

Committed patchset #1 (id:1) manually as
00743aa9758d6de3d7ebb932c4c4173f20a19da2 (presubmit successful).