Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1166163002: remove unused allowConstCast option (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove unused allowConstCast option this was for the Dart backend? R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/3b85674f41f2564beb9a47fa969d0d39b8a1f44a

Patch Set 1 #

Patch Set 2 : rebase against https://codereview.chromium.org/1169873002/ #

Patch Set 3 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -63 lines) Patch
M lib/src/checker/rules.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 1 5 chunks +3 lines, -36 lines 0 comments Download
M lib/src/options.dart View 1 2 6 chunks +3 lines, -14 lines 0 comments Download
M lib/src/testing.dart View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M test/checker/checker_test.dart View 1 chunk +1 line, -5 lines 0 comments Download
M test/codegen_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 6 months ago (2015-06-08 20:07:14 UTC) #2
vsm
lgtm
5 years, 6 months ago (2015-06-08 20:10:49 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-08 20:19:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3b85674f41f2564beb9a47fa969d0d39b8a1f44a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698