Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: lib/src/options.dart

Issue 1166163002: remove unused allowConstCast option (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: format Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/reify_coercions.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 599f2aa1c96f5e2de6c334e4e98b0ef3c23c2931..0902066bb86be3c687a3ace50c8c3fa695a473ae 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -73,9 +73,6 @@ class ResolverOptions {
// TODO(vsm): Merge RulesOptions and TypeOptions
/// Options used by our RestrictedRules.
class RulesOptions extends TypeOptions {
- /// Whether to allow casts in constant contexts.
- final bool allowConstCasts;
-
/// Whether to use covariant generics
final bool covariantGenerics;
@@ -93,7 +90,7 @@ class RulesOptions extends TypeOptions {
final bool wrapClosures;
static const wrapClosuresDefault = false;
- RulesOptions({this.allowConstCasts: true, this.covariantGenerics: true,
+ RulesOptions({this.covariantGenerics: true,
this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true,
this.ignoreTypes: false, this.wrapClosures: wrapClosuresDefault});
}
@@ -142,10 +139,6 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
/// File where to start compilation from.
final String entryPointFile;
- /// Whether to allow casts in constant contexts.
- @override
- final bool allowConstCasts;
-
/// Whether to run as a development server.
final bool serverMode;
@@ -227,9 +220,8 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
/// Custom URI mappings, such as "dart:foo" -> "path/to/foo.dart"
final Map<String, String> customUrlMappings;
- CompilerOptions({this.allowConstCasts: true, this.checkSdk: false,
- this.dumpInfo: false, this.dumpInfoFile, this.forceCompile: false,
- this.ignoreTypes: false,
+ CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
+ this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
this.wrapClosures: RulesOptions.wrapClosuresDefault, this.outputDir,
this.useColors: true, this.covariantGenerics: true,
this.relaxedCasts: true, this.useMultiPackage: false,
@@ -294,7 +286,6 @@ CompilerOptions parseOptions(List<String> argv) {
var entryPointFile = args.rest.length == 0 ? null : args.rest.first;
return new CompilerOptions(
- allowConstCasts: args['allow-const-casts'],
checkSdk: args['sdk-check'],
dumpInfo: dumpInfo,
dumpInfoFile: args['dump-info-file'],
@@ -335,8 +326,6 @@ CompilerOptions parseOptions(List<String> argv) {
final ArgParser argParser = new ArgParser()
// resolver/checker options
- ..addFlag('allow-const-casts',
- help: 'Allow casts in const contexts', defaultsTo: true)
..addFlag('sdk-check',
abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
..addFlag('mock-sdk',
« no previous file with comments | « lib/src/codegen/reify_coercions.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698