remove unused allowConstCast option

lib/src/options.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Set of flags and options passed to the compiler
 library dev_compiler.src.options;
 
 import 'dart:io';
 
 import 'package:args/args.dart';
@@ skipping 55 matching lines @@
       this.packagePaths: const <String>[], this.resources: const <String>[],
       this.inferFromOverrides: inferFromOverridesDefault,
       this.inferTransitively: inferTransitivelyDefault,
       this.onlyInferConstsAndFinalFields: onlyInferConstAndFinalFieldsDefault,
       this.entryPointFile: null, this.useImplicitHtml: false});
 }
 
 // TODO(vsm): Merge RulesOptions and TypeOptions
 /// Options used by our RestrictedRules.
 class RulesOptions extends TypeOptions {
-  /// Whether to allow casts in constant contexts.
-  final bool allowConstCasts;
-
   /// Whether to use covariant generics
   final bool covariantGenerics;
 
   /// Whether to infer types downwards from local context
   final bool inferDownwards;
   static const inferDownwardsDefault = true;
 
   /// Whether to inject casts between Dart assignable types.
   final bool relaxedCasts;
 
   /// Whether to use static types for code generation.
   final bool ignoreTypes;
 
   /// Whether to wrap closures for compatibility.
   final bool wrapClosures;
   static const wrapClosuresDefault = false;
 
-  RulesOptions({this.allowConstCasts: true, this.covariantGenerics: true,
+  RulesOptions({this.covariantGenerics: true,
       this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true,
       this.ignoreTypes: false, this.wrapClosures: wrapClosuresDefault});
 }
 
 class JSCodeOptions {
   /// Whether to emit the source map files.
   final bool emitSourceMaps;
 
   JSCodeOptions({this.emitSourceMaps: true});
 }
@@ skipping 28 matching lines @@
   /// Path to the dart-sdk. Null if `useMockSdk` is true or if the path couldn't
   /// be determined
   final String dartSdkPath;
 
   /// Minimum log-level reported on the command-line.
   final Level logLevel;
 
   /// File where to start compilation from.
   final String entryPointFile;
 
-  /// Whether to allow casts in constant contexts.
-  @override
-  final bool allowConstCasts;
-
   /// Whether to run as a development server.
   final bool serverMode;
 
   /// Whether to create an implicit HTML entry file in server mode.
   final bool useImplicitHtml;
 
   /// Whether to enable hash-based caching of files.
   final bool enableHashing;
 
   /// Port used for the HTTP server when [serverMode] is on.
@@ skipping 61 matching lines @@
   final bool emitSourceMaps;
 
   /// Location for runtime files, such as `dart_runtime.js`. By default this is
   /// inferred to be under `lib/runtime/` in the location of the `dev_compiler`
   /// package (if we can infer where that is located).
   final String runtimeDir;
 
   /// Custom URI mappings, such as "dart:foo" -> "path/to/foo.dart"
   final Map<String, String> customUrlMappings;
 
-  CompilerOptions({this.allowConstCasts: true, this.checkSdk: false,
-      this.dumpInfo: false, this.dumpInfoFile, this.forceCompile: false,
-      this.ignoreTypes: false,
+  CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
+      this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
       this.wrapClosures: RulesOptions.wrapClosuresDefault, this.outputDir,
       this.useColors: true, this.covariantGenerics: true,
       this.relaxedCasts: true, this.useMultiPackage: false,
       this.packageRoot: 'packages/', this.packagePaths: const <String>[],
       this.resources: const <String>[],
       this.inferDownwards: RulesOptions.inferDownwardsDefault,
       this.inferFromOverrides: ResolverOptions.inferFromOverridesDefault,
       this.inferTransitively: ResolverOptions.inferTransitivelyDefault,
       this.onlyInferConstsAndFinalFields: ResolverOptions.onlyInferConstAndFinalFieldsDefault,
       this.nonnullableTypes: TypeOptions.NONNULLABLE_TYPES, this.help: false,
@@ skipping 44 matching lines @@
     if (splitMapping.length != 2) {
       showUsage = true;
       continue;
     }
     customUrlMappings[splitMapping[0]] = splitMapping[1];
   }
 
   var entryPointFile = args.rest.length == 0 ? null : args.rest.first;
 
   return new CompilerOptions(
-      allowConstCasts: args['allow-const-casts'],
       checkSdk: args['sdk-check'],
       dumpInfo: dumpInfo,
       dumpInfoFile: args['dump-info-file'],
       forceCompile: args['force-compile'] || serverMode,
       ignoreTypes: args['ignore-types'],
       wrapClosures: args['wrap-closures'],
       outputDir: outputDir,
       covariantGenerics: args['covariant-generics'],
       relaxedCasts: args['relaxed-casts'],
       useColors: useColors,
@@ skipping 20 matching lines @@
       serverMode: serverMode,
       useImplicitHtml: serverMode && entryPointFile.endsWith('.dart'),
       enableHashing: enableHashing,
       host: args['host'],
       port: int.parse(args['port']),
       runtimeDir: runtimeDir);
 }
 
 final ArgParser argParser = new ArgParser()
   // resolver/checker options
-  ..addFlag('allow-const-casts',
-      help: 'Allow casts in const contexts', defaultsTo: true)
   ..addFlag('sdk-check',
       abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
   ..addFlag('mock-sdk',
       abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
   ..addFlag('covariant-generics',
       help: 'Use covariant generics', defaultsTo: true)
   ..addFlag('ignore-types',
       help: 'Ignore types during codegen', defaultsTo: false)
   ..addFlag('wrap-closures',
       help: 'wrap closures implicitly',
@@ skipping 109 matching lines @@
     // The pub-cache directory is two levels up, but we verify that the layout
     // looks correct.
     if (path.basename(dir) != 'dev_compiler') return null;
     dir = path.dirname(dir);
     if (path.basename(dir) != 'global_packages') return null;
     dir = path.dirname(dir);
     return path.join(dir, cacheDir, 'lib', 'runtime');
   }
   return null;
 }