chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/test_signin_client_builder.cc ('k') | chrome/browser/spellchecker/spellcheck_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc b/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

index 387636b9d00a7a04a6613042704d94fe65fe4572..dbd4da5a77cc333d3aaa61ab4b4b888f387024c5 100644

--- a/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

+++ b/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

@@ -7,6 +7,7 @@

#include <vector>

#include "base/files/file_util.h"

+#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram_samples.h"

#include "base/metrics/statistics_recorder.h"

#include "base/strings/string_number_conversions.h"

@@ -53,8 +54,9 @@ syncer::SyncDataList GetAllSyncDataNoLimit(

} // namespace

-static KeyedService* BuildSpellcheckService(content::BrowserContext* profile) {

- return new SpellcheckService(static_cast<Profile*>(profile));

+static scoped_ptr<KeyedService> BuildSpellcheckService(

+ content::BrowserContext* profile) {

+ return make_scoped_ptr(new SpellcheckService(static_cast<Profile*>(profile)));

}

class SpellcheckCustomDictionaryTest : public testing::Test {

« no previous file with comments | « chrome/browser/signin/test_signin_client_builder.cc ('k') | chrome/browser/spellchecker/spellcheck_service_unittest.cc » ('j') | no next file with comments »