chrome/browser/signin/test_signin_client_builder.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/test_signin_client_builder.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/test_signin_client_builder.h ('k') | chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/test_signin_client_builder.cc

diff --git a/chrome/browser/signin/test_signin_client_builder.cc b/chrome/browser/signin/test_signin_client_builder.cc

index d846fa01795ae9d8779f677d0a2b9655007eafe3..ef66af9ce74c6fdef755db221f5caf5da4937d47 100644

--- a/chrome/browser/signin/test_signin_client_builder.cc

+++ b/chrome/browser/signin/test_signin_client_builder.cc

@@ -7,19 +7,12 @@

#include "chrome/browser/profiles/profile.h"

#include "components/signin/core/browser/test_signin_client.h"

-class KeyedService;

-namespace content {

-class BrowserContext;

namespace signin {

-KeyedService* BuildTestSigninClient(

+scoped_ptr<KeyedService> BuildTestSigninClient(

content::BrowserContext* context) {

- TestSigninClient* test_signin_client =

- new TestSigninClient(static_cast<Profile*>(context)->GetPrefs());

- return test_signin_client;

+ return make_scoped_ptr(

+ new TestSigninClient(static_cast<Profile*>(context)->GetPrefs()));

}

} // namespace signin