chrome/browser/spellchecker/spellcheck_service_unittest.cc - Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 1165913002: [Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish renaming profile -> context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc ('k') | chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc

index 7cbc67bb7ac92f50c66541ee1dff2d3e84dba1f7..f2fd9f0fff6ec1c0396a87c99f5a38026f8f5f6a 100644

--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc

+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc

@@ -6,14 +6,16 @@

#include <algorithm>

+#include "base/memory/scoped_ptr.h"

#include "chrome/browser/spellchecker/feedback_sender.h"

#include "chrome/browser/spellchecker/spellcheck_factory.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "testing/gtest/include/gtest/gtest.h"

-static KeyedService* BuildSpellcheckService(content::BrowserContext* profile) {

- return new SpellcheckService(static_cast<Profile*>(profile));

+static scoped_ptr<KeyedService> BuildSpellcheckService(

+ content::BrowserContext* profile) {

+ return make_scoped_ptr(new SpellcheckService(static_cast<Profile*>(profile)));

}

class SpellcheckServiceTest : public testing::Test {