Issue 11659026: Fix JsObject#getProperties method so that it returns collection of JsObjectProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11659026: Fix JsObject#getProperties method so that it returns collection of JsObjectProperty (Closed)

Created:
7 years, 12 months ago by Peter Rybin

Modified:
7 years, 12 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix JsObject#getProperties method so that it returns collection of JsObjectProperty Committed: http://code.google.com/p/chromedevtools/source/detail?r=1115

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : comment #

Total comments: 2

Patch Set 4 : fcr #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -30 lines)			Patch
M	plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java	View	1 2 3	5 chunks	+48 lines, -19 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsVariableImpl.java	View	1 2	3 chunks	+54 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apavlov

7 years, 12 months ago (2012-12-26 09:13:45 UTC) #2

LGTM with comments

https://codereview.chromium.org/11659026/diff/3001/plugins/org.chromium.sdk/s...
File
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java
(right):

https://codereview.chromium.org/11659026/diff/3001/plugins/org.chromium.sdk/s...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java:292:
@Override
wrong indent

https://codereview.chromium.org/11659026/diff/3001/plugins/org.chromium.sdk/s...
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsObjectBase.java:302:
@Override
wrong indent

Expand Messages | Collapse Messages