plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java - Issue 11659026: Fix JsObject#getProperties method so that it returns collection of JsObjectProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java

Issue 11659026: Fix JsObject#getProperties method so that it returns collection of JsObjectProperty (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: fcr Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java

diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java

index cbc358e57eff9040f5ed86b4a6bbd9d2fbf2a15c..f9da3e450762d92dd653f8997fccd9f074bb971b 100755

--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java

+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/JsObject.java

@@ -23,10 +23,8 @@ public interface JsObject extends JsValue {

* @return the own properties of this compound value (does <strong>not</strong> include

* properties from proto object)

* @throws MethodIsBlockingException because it may need to load value from remote

- * TODO: make it return list of JsObjectProperty once hacks for supporting exceptions are

- * removed.

- Collection<? extends JsVariable> getProperties() throws MethodIsBlockingException;

+ Collection<? extends JsObjectProperty> getProperties() throws MethodIsBlockingException;

/**

* @return the internal properties of this compound value (e.g. those properties which

« no previous file with comments | « no previous file | plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/CallFrameImpl.java » ('j') | no next file with comments »