Issue 1165893002: Don’t claim success in GLSurface::InitializeOneOffInternal if the requested implementation type is …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165893002: Don’t claim success in GLSurface::InitializeOneOffInternal if the requested implementation type is … (Closed)

Created:
5 years, 6 months ago by iansf

Modified:
5 years, 6 months ago

Reviewers:
jamesr, abarth-chromium

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Don’t claim success in GLSurface::InitializeOneOffInternal if the requested implementation type is unknown. R=abarth@chromium.org, jamesr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/39888ed007879ec273ed45d7609211af843c83d7

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	ui/gl/gl_surface_android.cc	View		1 chunk	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://codereview.chromium.org/1165893002/diff/1/ui/gl/gl_surface_android.cc File ui/gl/gl_surface_android.cc (right): https://codereview.chromium.org/1165893002/diff/1/ui/gl/gl_surface_android.cc#newcode20 ui/gl/gl_surface_android.cc:20: auto implementation = GetGLImplementation(); It's not clear to me ...

5 years, 6 months ago (2015-06-03 21:55:06 UTC) #2

iansf

5 years, 6 months ago (2015-06-09 00:24:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
39888ed007879ec273ed45d7609211af843c83d7 (presubmit successful).

Expand Messages | Collapse Messages