Don’t claim success in GLSurface::InitializeOneOffInternal if the requested implementation type is …

ui/gl/gl_surface_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface.h"
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "third_party/khronos/EGL/egl.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_surface_egl.h"
 #include "ui/gl/gl_surface_osmesa.h"
 #include "ui/gl/gl_surface_stub.h"
 
 namespace gfx {
 
 // static
 bool GLSurface::InitializeOneOffInternal() {
-  switch (GetGLImplementation()) {
+  auto implementation = GetGLImplementation();

[abarth-chromium, 2015/06/03 21:55:06]

It's not clear to me whether |auto| is a good type to use here.  What sort of
thing does GetGLImplementation return?  Given that we use it in a switch, I
guess it is some sort of enum.  It seems like it would be better to write the
type explicitly.

+  switch (implementation) {
     case kGLImplementationEGLGLES2:
       if (!GLSurfaceEGL::InitializeOneOff()) {
         LOG(ERROR) << "GLSurfaceEGL::InitializeOneOff failed.";
         return false;
       }
+      break;
     default:
-      break;
+      LOG(ERROR)
+          << "Unknown GL implementation returned from GetGLImplementation: "
+          << implementation;
+      return false;
   }
   return true;
 }
 
 // static
 scoped_refptr<GLSurface> GLSurface::CreateViewGLSurface(
     gfx::AcceleratedWidget window) {
   CHECK_NE(kGLImplementationNone, GetGLImplementation());
   if (GetGLImplementation() == kGLImplementationOSMesaGL) {
     scoped_refptr<GLSurface> surface(new GLSurfaceOSMesaHeadless());
@@ skipping 44 matching lines @@
       NOTREACHED();
       return NULL;
   }
 }
 
 EGLNativeDisplayType GetPlatformDefaultEGLNativeDisplay() {
   return EGL_DEFAULT_DISPLAY;
 }
 
 }  // namespace gfx