Don’t claim success in GLSurface::InitializeOneOffInternal if the requested implementation type is …

ui/gl/gl_surface_android.cc

Index: ui/gl/gl_surface_android.cc
diff --git a/ui/gl/gl_surface_android.cc b/ui/gl/gl_surface_android.cc
index 1254da225bdcbed21d6fe76091e5bb6087099317..e87e9a8a1b9e97c65f02dce0e831d76ad66139ed 100644
--- a/ui/gl/gl_surface_android.cc
+++ b/ui/gl/gl_surface_android.cc
@@ -17,14 +17,19 @@ namespace gfx {
 
 // static
 bool GLSurface::InitializeOneOffInternal() {
-  switch (GetGLImplementation()) {
+  auto implementation = GetGLImplementation();

[abarth-chromium, 2015/06/03 21:55:06]

It's not clear to me whether |auto| is a good type to use here.  What sort of
thing does GetGLImplementation return?  Given that we use it in a switch, I
guess it is some sort of enum.  It seems like it would be better to write the
type explicitly.

+  switch (implementation) {
     case kGLImplementationEGLGLES2:
       if (!GLSurfaceEGL::InitializeOneOff()) {
         LOG(ERROR) << "GLSurfaceEGL::InitializeOneOff failed.";
         return false;
       }
-    default:
       break;
+    default:
+      LOG(ERROR)
+          << "Unknown GL implementation returned from GetGLImplementation: "
+          << implementation;
+      return false;
   }
   return true;
 }