Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(231)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1165753006: Update internal screen orientation headers and remove temporary redirects. (Closed)

Created:
4 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 10 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@move_screen_orientation_public
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update internal screen orientation headers and remove temporary redirects. This is part of a suite of three CLs: 1. https://codereview.chromium.org/1164753002 2. https://codereview.chromium.org/1151373005 3. <this> BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196717 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196961

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -53 lines) Patch
M Source/modules/screen_orientation/LockOrientationCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 chunk +1 line, -1 line 0 comments Download
D public/platform/WebLockOrientationCallback.h View 1 chunk +0 lines, -5 lines 0 comments Download
D public/platform/WebLockOrientationError.h View 1 chunk +0 lines, -5 lines 0 comments Download
M public/platform/WebScreenInfo.h View 1 chunk +1 line, -1 line 0 comments Download
D public/platform/WebScreenOrientationClient.h View 1 chunk +0 lines, -5 lines 0 comments Download
D public/platform/WebScreenOrientationLockType.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D public/platform/WebScreenOrientationType.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
4 years, 11 months ago (2015-06-02 10:36:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2015-06-02 16:19:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165753006/20001
4 years, 10 months ago (2015-06-08 22:18:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196717
4 years, 10 months ago (2015-06-09 00:45:41 UTC) #7
tkent
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1171783003/ by tkent@chromium.org. ...
4 years, 10 months ago (2015-06-09 02:33:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1165753006/20001
4 years, 10 months ago (2015-06-11 15:33:59 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 17:03:09 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196961

Powered by Google App Engine
This is Rietveld 408576698