Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1164753002: Move screen_orientation public headers to module directory. (Closed)

Created:
4 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 11 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move screen_orientation public headers to module directory. This is part of a suite of three CLs: 1. <this> 2. https://codereview.chromium.org/1151373005 3. https://codereview.chromium.org/1165753006 BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196331 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196413

Patch Set 1 #

Patch Set 2 : add missing headers #

Patch Set 3 : rebase #

Patch Set 4 : fix chrome os build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -90 lines) Patch
M public/platform/WebLockOrientationCallback.h View 1 1 chunk +1 line, -24 lines 0 comments Download
M public/platform/WebLockOrientationError.h View 1 1 chunk +1 line, -19 lines 0 comments Download
M public/platform/WebScreenOrientationClient.h View 1 chunk +1 line, -24 lines 0 comments Download
M public/platform/WebScreenOrientationType.h View 1 chunk +1 line, -16 lines 0 comments Download
A + public/platform/modules/screen_orientation/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/screen_orientation/WebLockOrientationCallback.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + public/platform/modules/screen_orientation/WebLockOrientationError.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/screen_orientation/WebScreenOrientationClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + public/platform/modules/screen_orientation/WebScreenOrientationLockType.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/modules/screen_orientation/WebScreenOrientationType.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mlamouri (slow - plz ping)
4 years, 11 months ago (2015-06-02 09:57:43 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2015-06-02 16:18:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164753002/20001
4 years, 11 months ago (2015-06-02 16:19:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196331
4 years, 11 months ago (2015-06-02 17:03:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164753002/60001
4 years, 11 months ago (2015-06-03 13:57:40 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 16:06:08 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196413

Powered by Google App Engine
This is Rietveld 408576698