Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1151373005: Update Blink's screen orientation path in Chromium. (Closed)

Created:
5 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, sadrul, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Blink's screen orientation path in Chromium. This is part of a suite of three CLs: 1. https://codereview.chromium.org/1164753002 2. <this> 3. https://codereview.chromium.org/1165753006 BUG=453032 Committed: https://crrev.com/3378bff7601c5927e6878f7c3a8082f741863f4c Cr-Commit-Position: refs/heads/master@{#333353}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix build #

Patch Set 4 : fix one include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M ash/content/display/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/mock_screen_orientation_client.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/screen_orientation/screen_orientation_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/assert_matching_enums.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/screen_orientation_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/manifest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/layouttest_support.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (12 generated)
mlamouri (slow - plz ping)
5 years, 6 months ago (2015-06-02 10:35:49 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-02 16:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151373005/20001
5 years, 6 months ago (2015-06-04 10:08:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/68291)
5 years, 6 months ago (2015-06-04 10:15:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151373005/40001
5 years, 6 months ago (2015-06-06 17:57:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/68974)
5 years, 6 months ago (2015-06-06 18:02:38 UTC) #13
mlamouri (slow - plz ping)
+nasko@ for content/common/ changes +oshima@ for ash/ changes.
5 years, 6 months ago (2015-06-06 18:15:23 UTC) #15
oshima
ash lgtm
5 years, 6 months ago (2015-06-07 04:37:50 UTC) #16
nasko
LGTM
5 years, 6 months ago (2015-06-08 17:41:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151373005/40001
5 years, 6 months ago (2015-06-08 18:03:07 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/72891)
5 years, 6 months ago (2015-06-08 19:08:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151373005/60001
5 years, 6 months ago (2015-06-08 20:49:25 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-08 21:53:38 UTC) #25
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 21:54:32 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3378bff7601c5927e6878f7c3a8082f741863f4c
Cr-Commit-Position: refs/heads/master@{#333353}

Powered by Google App Engine
This is Rietveld 408576698