Remove URLRequestStatus mutators and introduce FromError.

Remove URLRequestStatus mutators and introduce FromError.

As the first step to folding URLRequestStatus into net errors, remove mutators
so callers are required to specify status and error together. Also add a
FromError function which sets the status field automatically.

BUG=490309
Committed: https://crrev.com/e7938cf52a9aeb936c1cb005faaafb9f2b16cd4f
Cr-Commit-Position: refs/heads/master@{#332625}

[davidben, 2015-06-02 18:25:18]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-06-02 18:41:33]

LGTM, just nits.

https://codereview.chromium.org/1164823002/diff/1/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_interactive_uitest.cc (right):

https://codereview.chromium.org/1164823002/diff/1/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_interactive_uitest.cc:226: int error = success
? net::OK : net::ERR_FAILED;
Suggest making these net::Errors - not the current way of doing things, but
Eric's looking into changing that, so may as well make his life a little easier.

https://codereview.chromium.org/1164823002/diff/1/components/domain_reliabili...
File components/domain_reliability/monitor_unittest.cc (right):

https://codereview.chromium.org/1164823002/diff/1/components/domain_reliabili...
components/domain_reliability/monitor_unittest.cc:343: // removed.
Remove it?  But this test is awesome!

https://codereview.chromium.org/1164823002/diff/1/net/url_request/url_request...
File net/url_request/url_request_status.h (right):

https://codereview.chromium.org/1164823002/diff/1/net/url_request/url_request...
net/url_request/url_request_status.h:33: // URLRequestStatus::FromError instead.
Maybe "Use URLRequestStatus::FromError instead" -> "New consumers should..."

[davidben, 2015-06-02 19:19:42]

https://codereview.chromium.org/1164823002/diff/1/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_interactive_uitest.cc (right):

https://codereview.chromium.org/1164823002/diff/1/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_interactive_uitest.cc:226: int error = success
? net::OK : net::ERR_FAILED;
On 2015/06/02 18:41:33, mmenke wrote:
> Suggest making these net::Errors - not the current way of doing things, but
> Eric's looking into changing that, so may as well make his life a little
easier.

Done. Should I also change URLRequestStatus? I left that alone in case changing
the type of URLRS::error() would break stuff, but it's probably fine?

https://codereview.chromium.org/1164823002/diff/1/net/url_request/url_request...
File net/url_request/url_request_status.h (right):

https://codereview.chromium.org/1164823002/diff/1/net/url_request/url_request...
net/url_request/url_request_status.h:33: // URLRequestStatus::FromError instead.
On 2015/06/02 18:41:33, mmenke wrote:
> Maybe "Use URLRequestStatus::FromError instead" -> "New consumers should..."

Done.

[mmenke, 2015-06-02 19:22:26]

https://codereview.chromium.org/1164823002/diff/1/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_interactive_uitest.cc (right):

https://codereview.chromium.org/1164823002/diff/1/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_interactive_uitest.cc:226: int error = success
? net::OK : net::ERR_FAILED;
On 2015/06/02 19:19:42, David Benjamin wrote:
> On 2015/06/02 18:41:33, mmenke wrote:
> > Suggest making these net::Errors - not the current way of doing things, but
> > Eric's looking into changing that, so may as well make his life a little
> easier.
> 
> Done. Should I also change URLRequestStatus? I left that alone in case
changing
> the type of URLRS::error() would break stuff, but it's probably fine?

I guess we never store (Or *should* never store) bytes read in there, but I'm
sufficiently paranoid that I think we should just keep that as int for now.

[davidben, 2015-06-02 20:37:13]

davidben@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, isherman@chromium.org

[davidben, 2015-06-02 20:37:13]

+isherman for chrome/browser/autofill
+hajimehoshi for chrome/browser/translate

[Ilya Sherman, 2015-06-02 22:03:51]

autofill lgtm

[hajimehoshi, 2015-06-03 03:49:16]

translate lgtm

[davidben, 2015-06-03 15:33:03]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-06-03 15:33:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1164823002/#ps40001
(title: "typo")

[commit-bot: I haz the power, 2015-06-03 15:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164823002/40001

[commit-bot: I haz the power, 2015-06-03 16:24:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-03 16:24:56]

Patchset 3 (id:??) landed as
https://crrev.com/e7938cf52a9aeb936c1cb005faaafb9f2b16cd4f
Cr-Commit-Position: refs/heads/master@{#332625}