content/browser/speech/google_one_shot_remote_engine_unittest.cc - Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/google_one_shot_remote_engine_unittest.cc

Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/redirect_to_file_resource_handler.cc ('k') | content/browser/speech/speech_recognizer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/google_one_shot_remote_engine_unittest.cc

diff --git a/content/browser/speech/google_one_shot_remote_engine_unittest.cc b/content/browser/speech/google_one_shot_remote_engine_unittest.cc

index 16950102a2894af211f2c280db394e9aea42511a..3896f5cbfb072f4eea66ef1f94ea6aabf8496df2 100644

--- a/content/browser/speech/google_one_shot_remote_engine_unittest.cc

+++ b/content/browser/speech/google_one_shot_remote_engine_unittest.cc

@@ -8,6 +8,7 @@

#include "content/browser/speech/google_one_shot_remote_engine.h"

#include "content/public/common/speech_recognition_error.h"

#include "content/public/common/speech_recognition_result.h"

+#include "net/base/net_errors.h"

#include "net/url_request/test_url_fetcher_factory.h"

#include "net/url_request/url_request_context_getter.h"

#include "net/url_request/url_request_status.h"

@@ -65,10 +66,8 @@ void GoogleOneShotRemoteEngineTest::CreateAndTestRequest(

ASSERT_TRUE(fetcher);

fetcher->set_url(fetcher->GetOriginalURL());

- net::URLRequestStatus status;

- status.set_status(success ? net::URLRequestStatus::SUCCESS :

- net::URLRequestStatus::FAILED);

- fetcher->set_status(status);

+ fetcher->set_status(

+ net::URLRequestStatus::FromError(success ? net::OK : net::ERR_FAILED));

fetcher->set_response_code(success ? 200 : 500);

fetcher->SetResponseString(http_response);