net/url_request/url_fetcher_core.cc - Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_fetcher_core.cc

Issue 1164823002: Remove URLRequestStatus mutators and introduce FromError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_fetcher_core.cc

diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc

index d34f20f4d0919a1ad58108060c6e2f7cd5f3dcad..027991100532cb50d44c93a5d87c1a6ee789ca04 100644

--- a/net/url_request/url_fetcher_core.cc

+++ b/net/url_request/url_fetcher_core.cc

@@ -668,8 +668,7 @@ void URLFetcherCore::CancelURLRequest(int error) {

// URLRequestJob::NotifyDone(). But, because the request was released

// immediately after being canceled, the request could not call

// OnReadCompleted() which overwrites |status_| with the error status.

- status_.set_status(URLRequestStatus::CANCELED);

- status_.set_error(error);

+ status_ = URLRequestStatus(URLRequestStatus::CANCELED, error);

// Release the reference to the request context. There could be multiple

// references to URLFetcher::Core at this point so it may take a while to

« no previous file with comments | « net/net.gypi ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »