Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1164743002: [turbofan] Enable typed lowering of string addition. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable typed lowering of string addition. Unfortunately StringAdd is not pure in V8 because we might throw an exception if the resulting string length is outside the valid bounds, so there's no point in having a simplified StringAdd operator. R=jarin@chromium.org Committed: https://crrev.com/86b30420a844f3da33d9a9d4765b46d0c4554454 Cr-Commit-Position: refs/heads/master@{#28747}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -64 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +17 lines, -14 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/compiler/simplified-graph-builder.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 3 chunks +31 lines, -8 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-02 06:18:23 UTC) #1
Benedikt Meurer
Hey Jaro, Clean up after the decision on string add lowering was made. We have ...
5 years, 6 months ago (2015-06-02 06:19:39 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-02 08:36:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164743002/20001
5 years, 6 months ago (2015-06-02 08:49:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 08:50:51 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 08:51:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86b30420a844f3da33d9a9d4765b46d0c4554454
Cr-Commit-Position: refs/heads/master@{#28747}

Powered by Google App Engine
This is Rietveld 408576698