test/cctest/compiler/test-simplified-lowering.cc - Issue 1164743002: [turbofan] Enable typed lowering of string addition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-simplified-lowering.cc

Issue 1164743002: [turbofan] Enable typed lowering of string addition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/compiler/test-simplified-lowering.cc

diff --git a/test/cctest/compiler/test-simplified-lowering.cc b/test/cctest/compiler/test-simplified-lowering.cc

index 9b2346934c7111e147dce2e5142193d4322ef908..bc2634e19dfd4dc047c0452bc648314b91f3430d 100644

--- a/test/cctest/compiler/test-simplified-lowering.cc

+++ b/test/cctest/compiler/test-simplified-lowering.cc

@@ -1266,7 +1266,6 @@ TEST(LowerStringOps_to_call_and_compare) {

t.CheckLoweringBinop(compare_eq, t.simplified()->StringEqual());

t.CheckLoweringBinop(compare_lt, t.simplified()->StringLessThan());

t.CheckLoweringBinop(compare_le, t.simplified()->StringLessThanOrEqual());

- t.CheckLoweringBinop(IrOpcode::kCall, t.simplified()->StringAdd());

}