Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: src/compiler/verifier.cc

Issue 1164743002: [turbofan] Enable typed lowering of string addition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix tests. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/simplified-graph-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 CheckUpperIs(node, Type::Number()); 637 CheckUpperIs(node, Type::Number());
638 break; 638 break;
639 case IrOpcode::kStringEqual: 639 case IrOpcode::kStringEqual:
640 case IrOpcode::kStringLessThan: 640 case IrOpcode::kStringLessThan:
641 case IrOpcode::kStringLessThanOrEqual: 641 case IrOpcode::kStringLessThanOrEqual:
642 // (String, String) -> Boolean 642 // (String, String) -> Boolean
643 CheckValueInputIs(node, 0, Type::String()); 643 CheckValueInputIs(node, 0, Type::String());
644 CheckValueInputIs(node, 1, Type::String()); 644 CheckValueInputIs(node, 1, Type::String());
645 CheckUpperIs(node, Type::Boolean()); 645 CheckUpperIs(node, Type::Boolean());
646 break; 646 break;
647 case IrOpcode::kStringAdd:
648 // (String, String) -> String
649 CheckValueInputIs(node, 0, Type::String());
650 CheckValueInputIs(node, 1, Type::String());
651 CheckUpperIs(node, Type::String());
652 break;
653 case IrOpcode::kReferenceEqual: { 647 case IrOpcode::kReferenceEqual: {
654 // (Unique, Any) -> Boolean and 648 // (Unique, Any) -> Boolean and
655 // (Any, Unique) -> Boolean 649 // (Any, Unique) -> Boolean
656 CheckUpperIs(node, Type::Boolean()); 650 CheckUpperIs(node, Type::Boolean());
657 break; 651 break;
658 } 652 }
659 case IrOpcode::kObjectIsSmi: 653 case IrOpcode::kObjectIsSmi:
660 CheckValueInputIs(node, 0, Type::Any()); 654 CheckValueInputIs(node, 0, Type::Any());
661 CheckUpperIs(node, Type::Boolean()); 655 CheckUpperIs(node, Type::Boolean());
662 break; 656 break;
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1123 // Check inputs for all nodes in the block. 1117 // Check inputs for all nodes in the block.
1124 for (size_t i = 0; i < block->NodeCount(); i++) { 1118 for (size_t i = 0; i < block->NodeCount(); i++) {
1125 Node* node = block->NodeAt(i); 1119 Node* node = block->NodeAt(i);
1126 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1); 1120 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
1127 } 1121 }
1128 } 1122 }
1129 } 1123 }
1130 } // namespace compiler 1124 } // namespace compiler
1131 } // namespace internal 1125 } // namespace internal
1132 } // namespace v8 1126 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/simplified-graph-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698