Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: Source/core/css/CSSValuePool.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValueObject.cpp ('k') | Source/core/css/CSSValueTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValuePool.cpp
diff --git a/Source/core/css/CSSValuePool.cpp b/Source/core/css/CSSValuePool.cpp
index 2a5f672eafab70f7a3c9e97ec4dbe5336a98a53d..11443cca94ffb76270666ac8a9d64fe3dc2b582f 100644
--- a/Source/core/css/CSSValuePool.cpp
+++ b/Source/core/css/CSSValuePool.cpp
@@ -143,9 +143,9 @@ PassRefPtrWillBeRawPtr<CSSValueList> CSSValuePool::createFontFaceValue(const Ato
RefPtrWillBeMember<CSSValueList>& value = m_fontFaceValueCache.add(string, nullptr).storedValue->value;
if (!value) {
- RefPtrWillBeRawPtr<CSSValue> parsedValue = CSSParser::parseSingleValue(CSSPropertyFontFamily, string);
+ NullableCSSValue parsedValue = CSSParser::parseSingleValue(CSSPropertyFontFamily, string);
if (parsedValue && parsedValue->isValueList())
- value = toCSSValueList(parsedValue.get());
+ value = toCSSValueList(parsedValue);
}
return value;
}
« no previous file with comments | « Source/core/css/CSSValueObject.cpp ('k') | Source/core/css/CSSValueTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698