Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/core/css/CSSValuePool.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSValueObject.cpp ('k') | Source/core/css/CSSValueTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 136
137 PassRefPtrWillBeRawPtr<CSSValueList> CSSValuePool::createFontFaceValue(const Ato micString& string) 137 PassRefPtrWillBeRawPtr<CSSValueList> CSSValuePool::createFontFaceValue(const Ato micString& string)
138 { 138 {
139 // Just wipe out the cache and start rebuilding if it gets too big. 139 // Just wipe out the cache and start rebuilding if it gets too big.
140 const unsigned maximumFontFaceCacheSize = 128; 140 const unsigned maximumFontFaceCacheSize = 128;
141 if (m_fontFaceValueCache.size() > maximumFontFaceCacheSize) 141 if (m_fontFaceValueCache.size() > maximumFontFaceCacheSize)
142 m_fontFaceValueCache.clear(); 142 m_fontFaceValueCache.clear();
143 143
144 RefPtrWillBeMember<CSSValueList>& value = m_fontFaceValueCache.add(string, n ullptr).storedValue->value; 144 RefPtrWillBeMember<CSSValueList>& value = m_fontFaceValueCache.add(string, n ullptr).storedValue->value;
145 if (!value) { 145 if (!value) {
146 RefPtrWillBeRawPtr<CSSValue> parsedValue = CSSParser::parseSingleValue(C SSPropertyFontFamily, string); 146 NullableCSSValue parsedValue = CSSParser::parseSingleValue(CSSPropertyFo ntFamily, string);
147 if (parsedValue && parsedValue->isValueList()) 147 if (parsedValue && parsedValue->isValueList())
148 value = toCSSValueList(parsedValue.get()); 148 value = toCSSValueList(parsedValue);
149 } 149 }
150 return value; 150 return value;
151 } 151 }
152 152
153 DEFINE_TRACE(CSSValuePool) 153 DEFINE_TRACE(CSSValuePool)
154 { 154 {
155 #if ENABLE(OILPAN) 155 #if ENABLE(OILPAN)
156 visitor->trace(m_inheritedValue); 156 visitor->trace(m_inheritedValue);
157 visitor->trace(m_implicitInitialValue); 157 visitor->trace(m_implicitInitialValue);
158 visitor->trace(m_explicitInitialValue); 158 visitor->trace(m_explicitInitialValue);
159 visitor->trace(m_unsetValue); 159 visitor->trace(m_unsetValue);
160 visitor->trace(m_identifierValueCache); 160 visitor->trace(m_identifierValueCache);
161 visitor->trace(m_colorValueCache); 161 visitor->trace(m_colorValueCache);
162 visitor->trace(m_colorTransparent); 162 visitor->trace(m_colorTransparent);
163 visitor->trace(m_colorWhite); 163 visitor->trace(m_colorWhite);
164 visitor->trace(m_colorBlack); 164 visitor->trace(m_colorBlack);
165 visitor->trace(m_pixelValueCache); 165 visitor->trace(m_pixelValueCache);
166 visitor->trace(m_percentValueCache); 166 visitor->trace(m_percentValueCache);
167 visitor->trace(m_numberValueCache); 167 visitor->trace(m_numberValueCache);
168 visitor->trace(m_fontFaceValueCache); 168 visitor->trace(m_fontFaceValueCache);
169 visitor->trace(m_fontFamilyValueCache); 169 visitor->trace(m_fontFamilyValueCache);
170 #endif 170 #endif
171 } 171 }
172 172
173 } 173 }
OLDNEW
« no previous file with comments | « Source/core/css/CSSValueObject.cpp ('k') | Source/core/css/CSSValueTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698