Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: Source/core/css/CSSValueObject.cpp

Issue 1164573002: CSSValue Immediates: Change CSSValue to an object instead of a pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValueObject.h ('k') | Source/core/css/CSSValuePool.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValueObject.cpp
diff --git a/Source/core/css/CSSValue.cpp b/Source/core/css/CSSValueObject.cpp
similarity index 96%
rename from Source/core/css/CSSValue.cpp
rename to Source/core/css/CSSValueObject.cpp
index d8a94be96cb0712b2e146f95e0c2bab34ab8f683..0248bd8d865c83ddf3f6a989a8e6715bae771ec8 100644
--- a/Source/core/css/CSSValue.cpp
+++ b/Source/core/css/CSSValueObject.cpp
@@ -25,7 +25,7 @@
*/
#include "config.h"
-#include "core/css/CSSValue.h"
+#include "core/css/CSSValueObject.h"
#include "core/css/CSSBorderImageSliceValue.h"
#include "core/css/CSSCalculationValue.h"
@@ -56,19 +56,18 @@
namespace blink {
-struct SameSizeAsCSSValue : public RefCountedWillBeGarbageCollectedFinalized<SameSizeAsCSSValue>
-{
+struct SameSizeAsCSSValueObject : public RefCountedWillBeGarbageCollectedFinalized<SameSizeAsCSSValueObject> {
uint32_t bitfields;
};
-static_assert(sizeof(CSSValue) <= sizeof(SameSizeAsCSSValue), "CSSValue should stay small");
+static_assert(sizeof(CSSValueObject) <= sizeof(SameSizeAsCSSValueObject), "CSSValueObject should stay small");
-bool CSSValue::isImplicitInitialValue() const
+bool CSSValueObject::isImplicitInitialValue() const
{
return m_classType == InitialClass && toCSSInitialValue(this)->isImplicit();
}
-bool CSSValue::hasFailedOrCanceledSubresources() const
+bool CSSValueObject::hasFailedOrCanceledSubresources() const
{
if (isValueList())
return toCSSValueList(this)->hasFailedOrCanceledSubresources();
@@ -85,12 +84,12 @@ bool CSSValue::hasFailedOrCanceledSubresources() const
}
template<class ChildClassType>
-inline static bool compareCSSValues(const CSSValue& first, const CSSValue& second)
+inline static bool compareCSSValues(const CSSValueObject& first, const CSSValueObject& second)
{
return static_cast<const ChildClassType&>(first).equals(static_cast<const ChildClassType&>(second));
}
-bool CSSValue::equals(const CSSValue& other) const
+bool CSSValueObject::equals(const CSSValueObject& other) const
{
if (m_classType == other.m_classType) {
switch (m_classType) {
@@ -158,7 +157,7 @@ bool CSSValue::equals(const CSSValue& other) const
return false;
}
-String CSSValue::cssText() const
+String CSSValueObject::cssText() const
{
switch (classType()) {
case BorderImageSliceClass:
@@ -222,7 +221,7 @@ String CSSValue::cssText() const
return String();
}
-void CSSValue::destroy()
+void CSSValueObject::destroy()
{
switch (classType()) {
case BorderImageSliceClass:
@@ -313,7 +312,7 @@ void CSSValue::destroy()
ASSERT_NOT_REACHED();
}
-void CSSValue::finalizeGarbageCollectedObject()
+void CSSValueObject::finalizeGarbageCollectedObject()
{
switch (classType()) {
case BorderImageSliceClass:
@@ -404,7 +403,7 @@ void CSSValue::finalizeGarbageCollectedObject()
ASSERT_NOT_REACHED();
}
-DEFINE_TRACE(CSSValue)
+DEFINE_TRACE(CSSValueObject)
{
switch (classType()) {
case BorderImageSliceClass:
« no previous file with comments | « Source/core/css/CSSValueObject.h ('k') | Source/core/css/CSSValuePool.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698