Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1164553004: Revert of Mandoline: Remove native_viewport.mojom (Closed)

Created:
5 years, 6 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 6 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mandoline: Remove native_viewport.mojom (patchset #14 id:250001 of https://codereview.chromium.org/1149083010/) Reason for revert: This patch seems to break GN bots on Windows. See e.g. http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/8167 Original issue's description: > Mandoline: Remove native_viewport.mojom > > native_viewport mojom + app add a lot of unnecessary complexity. For now, this should be a part of the view_manager. A future patch will get rid of native_viewport completely and will teach display_manager to dispense platform_windows. > > BUG=487881 > Test=internal change only. > > Committed: https://crrev.com/3a4eab3f2f4fd8f7c7eb4d195c0e86a47e085d98 > Cr-Commit-Position: refs/heads/master@{#333183} TBR=sky@chromium.org,fsamuel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487881 Committed: https://crrev.com/57d15367b02b9123792a5c2193185983476a3762 Cr-Commit-Position: refs/heads/master@{#333245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+542 lines, -174 lines) Patch
M components/html_viewer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/html_document.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/view_manager/connection_manager.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/view_manager/connection_manager.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/view_manager/display_manager.h View 5 chunks +14 lines, -35 lines 0 comments Download
M components/view_manager/display_manager.cc View 5 chunks +38 lines, -69 lines 0 comments Download
M components/view_manager/event_dispatcher.h View 1 chunk +5 lines, -6 lines 0 comments Download
M components/view_manager/event_dispatcher.cc View 1 chunk +5 lines, -1 line 0 comments Download
M components/view_manager/native_viewport/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/view_manager/native_viewport/native_viewport_impl.h View 1 chunk +90 lines, -0 lines 0 comments Download
A components/view_manager/native_viewport/native_viewport_impl.cc View 1 chunk +166 lines, -0 lines 0 comments Download
M components/view_manager/native_viewport/platform_viewport.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/view_manager/native_viewport/platform_viewport_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/view_manager/native_viewport/platform_viewport_android.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M components/view_manager/native_viewport/platform_viewport_headless.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/native_viewport/platform_viewport_headless.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/view_manager/native_viewport/platform_viewport_x11.cc View 5 chunks +5 lines, -13 lines 0 comments Download
M components/view_manager/public/cpp/lib/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/view_manager/public/interfaces/native_viewport.mojom View 1 chunk +42 lines, -0 lines 0 comments Download
M components/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -6 lines 0 comments Download
M components/view_manager/view_manager_app.h View 3 chunks +6 lines, -0 lines 0 comments Download
M components/view_manager/view_manager_app.cc View 6 chunks +21 lines, -11 lines 0 comments Download
M components/view_manager/view_manager_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A mojo/runner/android/native_viewport_application_loader.h View 1 chunk +58 lines, -0 lines 0 comments Download
A mojo/runner/android/native_viewport_application_loader.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Mandoline: Remove native_viewport.mojom
5 years, 6 months ago (2015-06-08 06:56:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164553004/1
5 years, 6 months ago (2015-06-08 06:56:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 06:57:33 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 06:58:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57d15367b02b9123792a5c2193185983476a3762
Cr-Commit-Position: refs/heads/master@{#333245}

Powered by Google App Engine
This is Rietveld 408576698