Replace gfx::ClampToInt with base::saturated_cast.

Replace gfx::ClampToInt with base::saturated_cast.

This found a bug in saturated_cast that was covered by ClampToInt tests
so it fixes that.

If you have a floating point value of MAX_INT, then comparing an
integer against it for equality with promote it to a float and
it will compare true. However if you cast the float to an int, its
actually outside the bounds of integer, so you can end up with a
negative int as a result. Added unittests to check this for
saturated_cast.

Committed: https://crrev.com/3193742f0f9014ac342f54b0085986cef724252d
Cr-Commit-Position: refs/heads/master@{#333092}

[danakj, 2015-06-05 00:17:09]

danakj@chromium.org changed reviewers:
+ jschuh@chromium.org, sky@chromium.org

[danakj, 2015-06-05 00:19:59]

https://codereview.chromium.org/1164063005/diff/1/base/numerics/safe_conversi...
File base/numerics/safe_conversions_impl.h (right):

https://codereview.chromium.org/1164063005/diff/1/base/numerics/safe_conversi...
base/numerics/safe_conversions_impl.h:152:
value<std::numeric_limits<Dst>::max(), value> -
This is some good clang-format mistake here, filing a bug.

[sky, 2015-06-05 15:10:12]

I had to look at what saturated_cast does. IMO saturated does not describe what
the function does, but maybe that's because I am not in the know...

LGTM

[jschuh, 2015-06-05 15:54:21]

Nice catch. lgtm

As for the name, it's a reference to "saturation arithmetic", and seemed less
cumbersome than saturated_arithmetic_cast.

[sky, 2015-06-05 16:34:00]

constrain_to_valid? make_valid?

On Fri, Jun 5, 2015 at 8:54 AM,  <jschuh@chromium.org> wrote:
> Nice catch. lgtm
>
> As for the name, it's a reference to "saturation arithmetic", and seemed
> less
> cumbersome than saturated_arithmetic_cast.
>
> https://codereview.chromium.org/1164063005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2015-06-05 16:41:41]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-06-05 16:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jschuh@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1164063005/#ps80001
(title: "clamp: .")

[commit-bot: I haz the power, 2015-06-05 16:42:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1164063005/80001

[commit-bot: I haz the power, 2015-06-05 18:15:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-05 18:35:07]

Patchset 5 (id:??) landed as
https://crrev.com/3193742f0f9014ac342f54b0085986cef724252d
Cr-Commit-Position: refs/heads/master@{#333092}