Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: ui/gfx/geometry/safe_integer_conversions_unittest.cc

Issue 1164063005: Replace gfx::ClampToInt with base::saturated_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clamp: . Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gfx/geometry/safe_integer_conversions.h ('k') | ui/gfx/transform_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gfx/geometry/safe_integer_conversions.h" 5 #include "ui/gfx/geometry/safe_integer_conversions.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace gfx { 11 namespace gfx {
12 12
13 TEST(SafeIntegerConversions, ClampToInt) { 13 TEST(SafeIntegerConversions, ToFlooredInt) {
14 EXPECT_EQ(0, ClampToInt(std::numeric_limits<float>::quiet_NaN()));
15
16 float max = std::numeric_limits<int>::max(); 14 float max = std::numeric_limits<int>::max();
17 float min = std::numeric_limits<int>::min(); 15 float min = std::numeric_limits<int>::min();
18 float infinity = std::numeric_limits<float>::infinity(); 16 float infinity = std::numeric_limits<float>::infinity();
19
20 int int_max = std::numeric_limits<int>::max();
21 int int_min = std::numeric_limits<int>::min();
22
23 EXPECT_EQ(int_max, ClampToInt(infinity));
24 EXPECT_EQ(int_max, ClampToInt(max));
25 EXPECT_EQ(int_max, ClampToInt(max + 100));
26
27 EXPECT_EQ(-100, ClampToInt(-100.5f));
28 EXPECT_EQ(0, ClampToInt(0));
29 EXPECT_EQ(100, ClampToInt(100.5f));
30
31 EXPECT_EQ(int_min, ClampToInt(-infinity));
32 EXPECT_EQ(int_min, ClampToInt(min));
33 EXPECT_EQ(int_min, ClampToInt(min - 100));
34 }
35
36 TEST(SafeIntegerConversions, ToFlooredInt) {
37 EXPECT_EQ(0, ToFlooredInt(std::numeric_limits<float>::quiet_NaN()));
38
39 float max = std::numeric_limits<int>::max();
40 float min = std::numeric_limits<int>::min();
41 float infinity = std::numeric_limits<float>::infinity();
42 17
43 int int_max = std::numeric_limits<int>::max(); 18 int int_max = std::numeric_limits<int>::max();
44 int int_min = std::numeric_limits<int>::min(); 19 int int_min = std::numeric_limits<int>::min();
45 20
46 EXPECT_EQ(int_max, ToFlooredInt(infinity)); 21 EXPECT_EQ(int_max, ToFlooredInt(infinity));
47 EXPECT_EQ(int_max, ToFlooredInt(max)); 22 EXPECT_EQ(int_max, ToFlooredInt(max));
48 EXPECT_EQ(int_max, ToFlooredInt(max + 100)); 23 EXPECT_EQ(int_max, ToFlooredInt(max + 100));
49 24
50 EXPECT_EQ(-101, ToFlooredInt(-100.5f)); 25 EXPECT_EQ(-101, ToFlooredInt(-100.5f));
51 EXPECT_EQ(0, ToFlooredInt(0.f)); 26 EXPECT_EQ(0, ToFlooredInt(0.f));
52 EXPECT_EQ(100, ToFlooredInt(100.5f)); 27 EXPECT_EQ(100, ToFlooredInt(100.5f));
53 28
54 EXPECT_EQ(int_min, ToFlooredInt(-infinity)); 29 EXPECT_EQ(int_min, ToFlooredInt(-infinity));
55 EXPECT_EQ(int_min, ToFlooredInt(min)); 30 EXPECT_EQ(int_min, ToFlooredInt(min));
56 EXPECT_EQ(int_min, ToFlooredInt(min - 100)); 31 EXPECT_EQ(int_min, ToFlooredInt(min - 100));
57 } 32 }
58 33
59 TEST(SafeIntegerConversions, ToCeiledInt) { 34 TEST(SafeIntegerConversions, ToCeiledInt) {
60 EXPECT_EQ(0, ToCeiledInt(std::numeric_limits<float>::quiet_NaN()));
61
62 float max = std::numeric_limits<int>::max(); 35 float max = std::numeric_limits<int>::max();
63 float min = std::numeric_limits<int>::min(); 36 float min = std::numeric_limits<int>::min();
64 float infinity = std::numeric_limits<float>::infinity(); 37 float infinity = std::numeric_limits<float>::infinity();
65 38
66 int int_max = std::numeric_limits<int>::max(); 39 int int_max = std::numeric_limits<int>::max();
67 int int_min = std::numeric_limits<int>::min(); 40 int int_min = std::numeric_limits<int>::min();
68 41
69 EXPECT_EQ(int_max, ToCeiledInt(infinity)); 42 EXPECT_EQ(int_max, ToCeiledInt(infinity));
70 EXPECT_EQ(int_max, ToCeiledInt(max)); 43 EXPECT_EQ(int_max, ToCeiledInt(max));
71 EXPECT_EQ(int_max, ToCeiledInt(max + 100)); 44 EXPECT_EQ(int_max, ToCeiledInt(max + 100));
72 45
73 EXPECT_EQ(-100, ToCeiledInt(-100.5f)); 46 EXPECT_EQ(-100, ToCeiledInt(-100.5f));
74 EXPECT_EQ(0, ToCeiledInt(0.f)); 47 EXPECT_EQ(0, ToCeiledInt(0.f));
75 EXPECT_EQ(101, ToCeiledInt(100.5f)); 48 EXPECT_EQ(101, ToCeiledInt(100.5f));
76 49
77 EXPECT_EQ(int_min, ToCeiledInt(-infinity)); 50 EXPECT_EQ(int_min, ToCeiledInt(-infinity));
78 EXPECT_EQ(int_min, ToCeiledInt(min)); 51 EXPECT_EQ(int_min, ToCeiledInt(min));
79 EXPECT_EQ(int_min, ToCeiledInt(min - 100)); 52 EXPECT_EQ(int_min, ToCeiledInt(min - 100));
80 } 53 }
81 54
82 TEST(SafeIntegerConversions, ToRoundedInt) { 55 TEST(SafeIntegerConversions, ToRoundedInt) {
83 EXPECT_EQ(0, ToRoundedInt(std::numeric_limits<float>::quiet_NaN()));
84
85 float max = std::numeric_limits<int>::max(); 56 float max = std::numeric_limits<int>::max();
86 float min = std::numeric_limits<int>::min(); 57 float min = std::numeric_limits<int>::min();
87 float infinity = std::numeric_limits<float>::infinity(); 58 float infinity = std::numeric_limits<float>::infinity();
88 59
89 int int_max = std::numeric_limits<int>::max(); 60 int int_max = std::numeric_limits<int>::max();
90 int int_min = std::numeric_limits<int>::min(); 61 int int_min = std::numeric_limits<int>::min();
91 62
92 EXPECT_EQ(int_max, ToRoundedInt(infinity)); 63 EXPECT_EQ(int_max, ToRoundedInt(infinity));
93 EXPECT_EQ(int_max, ToRoundedInt(max)); 64 EXPECT_EQ(int_max, ToRoundedInt(max));
94 EXPECT_EQ(int_max, ToRoundedInt(max + 100)); 65 EXPECT_EQ(int_max, ToRoundedInt(max + 100));
95 66
96 EXPECT_EQ(-100, ToRoundedInt(-100.1f)); 67 EXPECT_EQ(-100, ToRoundedInt(-100.1f));
97 EXPECT_EQ(-101, ToRoundedInt(-100.5f)); 68 EXPECT_EQ(-101, ToRoundedInt(-100.5f));
98 EXPECT_EQ(-101, ToRoundedInt(-100.9f)); 69 EXPECT_EQ(-101, ToRoundedInt(-100.9f));
99 EXPECT_EQ(0, ToRoundedInt(0.f)); 70 EXPECT_EQ(0, ToRoundedInt(0.f));
100 EXPECT_EQ(100, ToRoundedInt(100.1f)); 71 EXPECT_EQ(100, ToRoundedInt(100.1f));
101 EXPECT_EQ(101, ToRoundedInt(100.5f)); 72 EXPECT_EQ(101, ToRoundedInt(100.5f));
102 EXPECT_EQ(101, ToRoundedInt(100.9f)); 73 EXPECT_EQ(101, ToRoundedInt(100.9f));
103 74
104 EXPECT_EQ(int_min, ToRoundedInt(-infinity)); 75 EXPECT_EQ(int_min, ToRoundedInt(-infinity));
105 EXPECT_EQ(int_min, ToRoundedInt(min)); 76 EXPECT_EQ(int_min, ToRoundedInt(min));
106 EXPECT_EQ(int_min, ToRoundedInt(min - 100)); 77 EXPECT_EQ(int_min, ToRoundedInt(min - 100));
107 } 78 }
108 79
109 } // namespace gfx 80 } // namespace gfx
OLDNEW
« no previous file with comments | « ui/gfx/geometry/safe_integer_conversions.h ('k') | ui/gfx/transform_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698