Issue 1163393002: remove ignoreTypes flag, to reimplement later, see #134

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163393002: remove ignoreTypes flag, to reimplement later, see #134 (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

remove ignoreTypes flag, it doesn't work, see #134 If we wanted to bring this back, we should implement it differently, IMO Instead simply replace all type annotations with `dynamic` R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/93285f4d554e9fa0915c50851a0fd6cdec649b82

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -24 lines)			Patch
M	lib/src/checker/rules.dart	View	1 2	2 chunks	+3 lines, -6 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/src/options.dart	View	1 2	5 chunks	+4 lines, -14 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 6 months ago (2015-06-08 23:57:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
93285f4d554e9fa0915c50851a0fd6cdec649b82 (presubmit successful).