Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1163393002: remove ignoreTypes flag, to reimplement later, see #134 (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/rules.dart ('k') | lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 1749ca742cde6543c3bce6a52615e60543ad2c73..28ba34dc6c3c6d2a8434e5793ad82e28ad425834 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -1879,10 +1879,6 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
var leftType = getStaticType(left);
var rightType = getStaticType(right);
- // TODO(jmesserly): this may not work correctly with options.ignoreTypes,
- // because that results in unreliable type annotations. See issue #134,
- // probably the checker/resolver is the right place to implement that, by
- // replacing staticTypes with `dynamic` as needed, so codegen "just works".
var code;
if (op.type.isEqualityOperator) {
// If we statically know LHS or RHS is null we can generate a clean check.
« no previous file with comments | « lib/src/checker/rules.dart ('k') | lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698