Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: lib/src/options.dart

Issue 1163393002: remove ignoreTypes flag, to reimplement later, see #134 (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index e2711dfbea57d4d1ee023e70a0fa0fdf91c99b5f..7916e58753eb51bbe63eed62aa7d94e8ba2044ed 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -80,11 +80,8 @@ class RulesOptions extends TypeOptions {
/// Whether to inject casts between Dart assignable types.
final bool relaxedCasts;
- /// Whether to use static types for code generation.
- final bool ignoreTypes;
-
- RulesOptions({this.inferDownwards: inferDownwardsDefault,
- this.relaxedCasts: true, this.ignoreTypes: false});
+ RulesOptions(
+ {this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true});
}
class JSCodeOptions {
@@ -188,10 +185,6 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
@override
final List<String> nonnullableTypes;
- /// Whether to use static types for code generation.
- @override
- final bool ignoreTypes;
-
/// Whether to emit the source map files.
@override
final bool emitSourceMaps;
@@ -205,8 +198,8 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
final Map<String, String> customUrlMappings;
CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
- this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
- this.outputDir, this.useColors: true, this.relaxedCasts: true,
+ this.dumpInfoFile, this.forceCompile: false, this.outputDir,
+ this.useColors: true, this.relaxedCasts: true,
this.useMultiPackage: false, this.packageRoot: 'packages/',
this.packagePaths: const <String>[], this.resources: const <String>[],
this.inferDownwards: RulesOptions.inferDownwardsDefault,
@@ -272,7 +265,6 @@ CompilerOptions parseOptions(List<String> argv) {
dumpInfo: dumpInfo,
dumpInfoFile: args['dump-info-file'],
forceCompile: args['force-compile'] || serverMode,
- ignoreTypes: args['ignore-types'],
outputDir: outputDir,
relaxedCasts: args['relaxed-casts'],
useColors: useColors,
@@ -310,8 +302,6 @@ final ArgParser argParser = new ArgParser()
abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
..addFlag('mock-sdk',
abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
- ..addFlag('ignore-types',
- help: 'Ignore types during codegen', defaultsTo: false)
..addFlag('relaxed-casts',
help: 'Cast between Dart assignable types', defaultsTo: true)
..addOption('nonnullable',
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698