Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1162623011: Fix some minor warnings from the analyzer in the framework. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 6 months ago (2015-06-04 21:10:44 UTC) #2
Hixie
5 years, 6 months ago (2015-06-04 21:11:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
392761d8dde46d2d0b3f985d9e9fea2d2749b715 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698